Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow child bucket sub-path to contains forward slashes #205

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

TimCsaky
Copy link
Contributor

Description

When adding adding a sub-folder, allow user to enter a path that traverses multiple folder levels.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • [x ] I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

github-actions bot commented May 27, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 19.2% ( 706 / 3678 )
Methods: 18.72% ( 134 / 716 )
Lines: 22.97% ( 491 / 2138 )
Branches: 9.83% ( 81 / 824 )

Copy link

codeclimate bot commented May 27, 2024

Code Climate has analyzed commit 9db69b8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.2%.

View more on Code Climate.

@TimCsaky TimCsaky marked this pull request as ready for review May 27, 2024 23:35
@TimCsaky TimCsaky requested review from norrisng-bc and jatindersingh93 and removed request for jatindersingh93 and norrisng-bc May 27, 2024 23:36
@TimCsaky TimCsaky force-pushed the bug/child branch 5 times, most recently from 433273c to 02084c2 Compare May 30, 2024 00:26
@TimCsaky TimCsaky merged commit ec89a9f into master May 30, 2024
18 of 19 checks passed
@TimCsaky TimCsaky deleted the bug/child branch May 30, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants